RuboCop Inspection Report

dragnet.gemspec - 1 offense

Line #5 – convention: Metrics/BlockLength: Block has too many lines. [26/25]

Gem::Specification.new do |spec| ...

lib/dragnet/cli.rb - 1 offense

Line #3 – convention: Style/RedundantFileExtensionInRequire: Redundant .rb file extension detected.

require_relative 'cli/master.rb'

lib/dragnet/validator.rb - 1 offense

Line #44 – convention: Metrics/MethodLength: Method has too many lines. [17/15]

    def validate_file(file) ...

lib/dragnet/validators/data_validator.rb - 1 offense

Line #20 – warning: Lint/MissingSuper: Call super to initialize state of the parent class.

      def initialize(data, source_file) ...

lib/dragnet/validators/entities/test_record_validator.rb - 2 offenses

Line #28 – convention: Metrics/AbcSize: Assignment Branch Condition size for validate is too high. [<2, 23, 0> 23.09/17]

        def validate ...

Line #64 – convention: Metrics/AbcSize: Assignment Branch Condition size for repos_xor_sha1 is too high. [<1, 17, 2> 17.15/17]

        def repos_xor_sha1 ...

lib/dragnet/validators/fields/sha1_validator.rb - 1 offense

Line #12 – convention: Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

        SHA1_REGEX = /\A[0-9a-f]+\Z/.freeze

lib/dragnet/validators/files_validator.rb - 1 offense

Line #20 – warning: Lint/MissingSuper: Call super to initialize state of the parent class.

      def initialize(test_record, path) ...

lib/dragnet/validators/repos_validator.rb - 1 offense

Line #15 – warning: Lint/MissingSuper: Call super to initialize state of the parent class.

      def initialize(test_record, path) ...

spec/dragnet/cli/master_spec.rb - 1 offense

Line #589 – convention: Layout/LineLength: Line is too long. [126/120]

            test_records: test_records, errors: errors, repository: repository_instance, targets: export_files, logger: logger

spec/dragnet/exporters/html_exporter_spec.rb - 1 offense

Line #60 – convention: RSpec/StubbedMock: Prefer allow over expect when configuring a response.

      expect(File).to receive(:read).with(described_class::TEMPLATE).and_return(template)

spec/dragnet/multi_repository_spec.rb - 2 offenses

Line #52 – convention: RSpec/BeEq: Prefer be over eq.

      expect(multi_repository.multi?).to eq(true)

Line #121 – convention: Layout/TrailingEmptyLines: 1 trailing blank lines detected.

spec/dragnet/repository_spec.rb - 1 offense

Line #165 – convention: RSpec/BeEq: Prefer be over eq.

      expect(method_call).to eq(false)

spec/dragnet/test_record_spec.rb - 12 offenses

Line #51 – convention: Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

        { review_status: review_status, reviewstatus: 'something else'}

Line #77 – convention: Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

        { review_comments: review_comments, reviewcomments: '-'}

Line #191 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

Line #199 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #209 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

Line #217 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #229 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #237 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #245 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #254 – convention: RSpec/BeEq: Prefer be over eq.

          expect(method_call).to eq(false)

Line #262 – convention: RSpec/BeEq: Prefer be over eq.

          expect(method_call).to eq(false)

Line #271 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

spec/dragnet/validator_spec.rb - 1 offense

Line #318 – convention: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.

spec/dragnet/validators/entities/test_record_validator_spec.rb - 1 offense

Line #233 – convention: Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

          { path: 'esrlabs/bsw/safeRng', sha1: '75430dc90b1e82ef8a688c7bf036eb48f6941b8a', files: '**/**/*.cpp'}

spec/dragnet/validators/fields/files_validator_spec.rb - 1 offense

Line #59 – convention: Layout/TrailingEmptyLines: 1 trailing blank lines detected.

spec/dragnet/validators/fields/sha1_validator_spec.rb - 1 offense

Line #5 – convention: Style/RedundantFileExtensionInRequire: Redundant .rb file extension detected.

require_relative 'field_validator_shared.rb'

spec/dragnet/validators/files_validator_spec.rb - 1 offense

Line #71 – convention: Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

          "Could not find any files matching #{file} in #{path}")

spec/dragnet/verification_result_spec.rb - 6 offenses

Line #59 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

Line #67 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #77 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #85 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

Line #95 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(false)

Line #103 – convention: RSpec/BeEq: Prefer be over eq.

        expect(method_call).to eq(true)

spec/dragnet_spec.rb - 1 offense

Line #5 – convention: RSpec/BeNil: Prefer be_nil over be(nil).

    expect(Dragnet::VERSION).not_to be nil

spec/integration/dragnet/exporters/html_exporter_spec.rb - 2 offenses

Line #466 – convention: Layout/SpaceInsideParens: Space inside parentheses detected.

        Dragnet::TestRecord.new(sha1: '04aec23' ).tap do |test_record|

Line #479 – convention: Layout/SpaceInsideParens: Space inside parentheses detected.

        Dragnet::TestRecord.new(sha1: 'f13dbbc' ).tap do |test_record|